Weasel was right about older games being unable to run on vista etc. But then again It's all up to you. XP is still the king in terms of speed and compatibilty unlike Vista. I'm using both XP and Vista and i think Vista still need more improvements and don't forget it consume more ram than XP.
And to make matter worse microsoft is planning to launch a new os in the next two years or so. Vista = Windows ME? It could be right on track...Just like Windows ME gets a good spanking by Windows XP